-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWGHF: Add Selector Variables for Lc->PKPi Selector task #7907
Conversation
phymanshu
commented
Oct 7, 2024
- Adding selector variables in Lc->PKPi selector similar to Xic->PKPi
Add More Variables in the LcToPKPi selector
Add More Selector Variables
PWGHF/Core/SelectorCuts.h
Outdated
// default values for the cuts m, ptP, ptK, ptPi, chi2PCA, dL, cosp, dLXY, NdLXY, ct, ImpParXY mass(Kpi) | ||
constexpr double cuts[nBinsPt][nCutVars] = {{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 0 < pT < 1 */ | ||
{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 1 < pT < 2 */ | ||
{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 2 < pT < 3 */ | ||
{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 3 < pT < 4 */ | ||
{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 4 < pT < 5 */ | ||
{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 5 < pT < 6 */ | ||
{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 6 < pT < 8 */ | ||
{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 8 < pT < 12 */ | ||
{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 12 < pT < 24 */ | ||
{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}}; /* 24 < pT < 36 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @phymanshu , ok for me to add such cuts if needed, however I'd use default values such that no new selections are applied (i.e.: I'd use 0
as default for decLengthXY
and normDecLXY
, and 1e+10
for ct
and impParXY
)
Please consider the following formatting changes to AliceO2Group#7907
// candidate ct | ||
if (hfHelper.ctXic(candidate) > cuts->get(pTBin, "ct")) { | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you really need a cut on hfHelper.ctXic(candidate)
? If yes, I'd anyway remove it from the default selections for Lambdac, and eventually add a specific Configurable
in the selector. I do not like the idea to have a Xic-related cut in the code of Lambdac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfaggin Good catch!